[PATCH] D24466: [PPC] Set SP after loading data from stack frame, if no red zone is present

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

This LGTM, with two minor things:

1. The form of the copies (see below)
2. Our test coverage here seems a bit sparse. Can you please add a few more test cases to cover the (large frame vs small frame) x (with frame pointer vs. without frame pointer) x (with base pointer vs. without base pointer) configurations?


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1348
@@ +1347,3 @@
+            .addReg(FPReg)
+            .addImm(0);
+        RBReg = FPReg;
----------------
The code in PPCInstrInfo::copyPhysReg copies, canonically, by or'ing the value with itself. I'd prefer you use that, as the canonical representation, here.

================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1435
@@ +1434,3 @@
+        .addReg(ScratchReg)
+        .addImm(0);
+
----------------
Same comment here about the copy.


Repository:
  rL LLVM

https://reviews.llvm.org/D24466