[PATCH] D20582: Don't add repeats of llvm.ident list when linking

[Duncan P. N. Exon Smith via llvm-commits]

Sorry for the long delay on this one Matt.

Do you have any thoughts on Jan's question above?
> Is there a reason not to dedup all metadata nodes?

It does seem strange to me to apply this to !llvm.ident, but nothing else.  I don't know if we want to special case it.  I'm also slightly concerned that this is quadratic in the number of unique nodes referenced; not we'll suddenly have a large number of separate compilers, but we couldn't efficiently extend this to other cases.

I wonder what it would take to give NamedMDNode the semantics of a SetVector?  This would require an llvm-dev discussion, but I don't know of any current metadata uses where it would be problematic, and then addOperand will just "do the right thing".

> On 2016-Sep-12, at 10:24, Matt Arsenault <Matthew.Arsenault at amd.com> wrote:
> 
> arsenm added a comment.
> 
> ping
> 
> 
> https://reviews.llvm.org/D20582
> 
> 
>