[PATCH] D24073: [AArch64] Support stackmap/patchpoint in getInstSizeInBytes

[Kavon Farvardin via llvm-commits]

kavon accepted this revision.
kavon added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D24073#539679, @rovka wrote:

> In https://reviews.llvm.org/D24073#539438, @kavon wrote:
>
> > When the op code is a patchpoint, isn't a call still emitted? I think maybe the total number of bytes returned for patchpoints should include the bytes for the call.
>
>
> From my reading of AArch64AsmPrinter::LowerPATCHPOINT, it looks like the number of bytes requested by the patchpoint has to include the bytes for the call - i.e. if the call is generated, its size is subtracted from the number of bytes requested, and only the remaining number of nops are added.


Ah, okay. This looks good to me then. I'm a newcomer when it comes to contributing patches, so I'm not sure what else I should do. :)


https://reviews.llvm.org/D24073