[lld] r281209 - Revert "Revert "Compact InputSectionData from 64 to 48 bytes. NFC.""

[Rafael Espindola via llvm-commits]

Author: rafael
Date: Mon Sep 12 08:06:10 2016
New Revision: 281209

URL: http://llvm.org/viewvc/llvm-project?rev=281209&view=rev
Log:
Revert "Revert "Compact InputSectionData from 64 to 48 bytes. NFC.""

This reverts commit r281096.

The previous link errors should be fixed by r281208.

Modified:
    lld/trunk/ELF/InputSection.cpp
    lld/trunk/ELF/InputSection.h

Modified: lld/trunk/ELF/InputSection.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.cpp?rev=281209&r1=281208&r2=281209&view=diff
==============================================================================
--- lld/trunk/ELF/InputSection.cpp (original)
+++ lld/trunk/ELF/InputSection.cpp Mon Sep 12 08:06:10 2016
@@ -50,8 +50,8 @@ template <class ELFT> size_t InputSectio
 template <class ELFT>
 ArrayRef<uint8_t> InputSectionBase<ELFT>::getSectionData() const {
   if (Compressed)
-    return ArrayRef<uint8_t>((const uint8_t *)Uncompressed.data(),
-                             Uncompressed.size());
+    return ArrayRef<uint8_t>((const uint8_t *)UncompressedData.get(),
+                             UncompressedDataSize);
   return check(this->File->getObj().getSectionContents(this->Header));
 }
 
@@ -106,7 +106,10 @@ template <class ELFT> void InputSectionB
     fatal(getName(this) + ": unsupported compression type");
 
   StringRef Buf((const char *)Data.data(), Data.size());
-  if (zlib::uncompress(Buf, Uncompressed, Hdr->ch_size) != zlib::StatusOK)
+  UncompressedDataSize = Hdr->ch_size;
+  UncompressedData.reset(new char[UncompressedDataSize]);
+  if (zlib::uncompress(Buf, UncompressedData.get(), UncompressedDataSize) !=
+      zlib::StatusOK)
     fatal(getName(this) + ": error uncompressing section");
 }
 

Modified: lld/trunk/ELF/InputSection.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.h?rev=281209&r1=281208&r2=281209&view=diff
==============================================================================
--- lld/trunk/ELF/InputSection.h (original)
+++ lld/trunk/ELF/InputSection.h Mon Sep 12 08:06:10 2016
@@ -61,8 +61,9 @@ public:
 
   StringRef Name;
 
-  // If a section is compressed, this vector has uncompressed section data.
-  SmallVector<char, 0> Uncompressed;
+  // If a section is compressed, this has the uncompressed section data.
+  std::unique_ptr<char[]> UncompressedData;
+  size_t UncompressedDataSize = 0;
 
   std::vector<Relocation> Relocations;
 };