[PATCH] D24450: [ELF] Linkerscript: improve handling of ASSERT and symbol assignment outside SECTIONS block

[Simon Atanasyan via llvm-commits]

atanasyan added a comment.

Is it possible to do s/HasContents/HasSections/ renaming as a separate commit to reduce diffs? It looks like this change is separable from this patch.


================
Comment at: ELF/Writer.cpp:258
@@ -259,1 +257,3 @@
+    Script<ELFT>::X->processCommands(Factory);
+  }
 
----------------
Is it important that we call `processCommands` in the beginning of the `LinkerScript::createSections` but after the `Writer::createSections`? If it does not matter, for my taste it is better to remove the `processCommands` call from the `LinkerScript::createSections` and do it here to accentuate that we always process commands from linker scripts.

```
  Script<ELFT>::X->processCommands(Factory);
  if (ScriptConfig->HasSections)
    Script<ELFT>::X->createSections(Factory);
  else
    createSections();
```


Repository:
  rL LLVM

https://reviews.llvm.org/D24450