[PATCH] D24294: [ELF] - Implemented --section-start, -Ttext, -Tdata, -Tbss options.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 11 01:39:14 PDT 2016


grimar added inline comments.

================
Comment at: ELF/Driver.cpp:380
@@ +379,3 @@
+  if (S.getAsInteger(16, VA))
+    error("invalid argument for --section-start/-Tbss/-Tdata/-Ttext: " + S);
+  return VA;
----------------
ruiu wrote:
> Please do whatever to make it user friendly.
Well if I would be user, I would be happy to see a detailed message and not the common, so to make it more user friendly I would probably suggest to split reporting. 
That also helps to keep code a bit more clean because --section-start as handled a bit differently from other 3 options.
Updated the patch, what do you think ?


https://reviews.llvm.org/D24294





More information about the llvm-commits mailing list