[PATCH] D24267: [ELF] - Added support of --gdb-index command line option.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 10 01:26:46 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D24267#538684, @ruiu wrote:

> I'm still reading this patch and haven't got the whole picture yet. A few swing-by comments. Please do it incrementally next time. You don't need to make up a complete, working code from day one -- but you can incrementally build a feature in the public repository, and it is actually more appreciated way of doing it than dropping a complete large patch out of the blue.


I am really sorry, do not want inconvenience for anyone. My suggestion is next then. What if I`ll split this patch to several ? I mean them will not be workable, first one can just generate the gdb_index section itself and some part of data. So it can be a sequence of patches which will make the functionality workable after the last one is committed.
What do you think ?


https://reviews.llvm.org/D24267





More information about the llvm-commits mailing list