[PATCH] D23370: [CodeGen] Rename MachineInstr::isInvariantLoad to isDereferenceableInvariantLoad. NFC

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 18:04:56 PDT 2016


hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.

================
Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:1128
@@ +1127,3 @@
+  /// Return true if this load instruction never traps and points to a memory
+  /// location whose value doesn't change over the course of this function.
+  ///
----------------
"over the course of this function" sounds a bit too colloquial to me. Can we say, "during the execution of this function."?

Regardless, this LGTM too.


https://reviews.llvm.org/D23370





More information about the llvm-commits mailing list