[PATCH] D24423: X86: Fold tail calls into conditional branches also for 64-bit (PR26302)

[Hans Wennborg via llvm-commits]

hans marked 2 inline comments as done.
hans added a comment.

Thanks for the review!


================
Comment at: lib/Target/X86/X86InstrControl.td:266
@@ -265,3 +265,3 @@
                            (ins i32imm_pcrel:$dst, i32imm:$cond),
-                           "",
+                           "tailjmpd_cc",
                            [], IIC_JMP_REL>;
----------------
mkuper wrote:
> Do we ever expect to print this? Is this just for debugging?
> (Will this cause us to end up allowing this in the asm reader?)
For a moment I thought we printed these in debug output somewhere, but now I can't find anywhere that do. I'll just remove it.

================
Comment at: lib/Target/X86/X86InstrControl.td:311
@@ +310,3 @@
+                        []>;
+  def TCRETURNdicc64 : PseudoI<(outs),
+                        (ins i64i32imm_pcrel:$dst, i32imm:$offset,
----------------
mkuper wrote:
> Totally nitpicking, but maybe di64cc (which will also better match d64_CC below)?
Sounds good to me.


https://reviews.llvm.org/D24423