[PATCH] D24394: [asan] Reify ErrorStringFunctionSizeOverflow

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 15:06:32 PDT 2016


vitalybuka added inline comments.

================
Comment at: lib/asan/asan_errors.h:241
@@ +240,3 @@
+  ErrorStringFunctionSizeOverflow() = default;
+  ErrorStringFunctionSizeOverflow(u32 tid_, BufferedStackTrace *stack_,
+                                  uptr addr, uptr size_)
----------------
Please make consistent arguments order 
also "tid" could be in ErrorBase


https://reviews.llvm.org/D24394





More information about the llvm-commits mailing list