[PATCH] D23906: LSV: Fix incorrectly increasing alignment

[Justin Lebar via llvm-commits]

jlebar accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:798
@@ -800,1 +797,3 @@
+                                                   DL, S0, nullptr, &DT);
+    if (NewAlign < StackAdjustedAlignment)
       return false;
----------------
arsenm wrote:
> It doesn't actually return 0 on failure, it returns the known alignment. In the motivating testcase, load_unknown_offset_align1_i8, it returns 1 when it can't find the constant offset
I looked through the code and agree that it is as you describe.

It may be worth fixing the comment in Local.h.


https://reviews.llvm.org/D23906