[PATCH] D24325: [LLVM] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings in unittests and utils; other minor fixes

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: utils/PerfectShuffle/PerfectShuffle.cpp:425
@@ -426,3 +424,3 @@
 
-  if (0) {
+  if (false) {
     // Print out the table.
----------------
This is horrible.  We shouldnt leave dead code, and this should really be moved into a DEBUG() statement.  However, that is beyond the scope of this particular change, and that isnt your fault.

================
Comment at: utils/TableGen/CodeGenDAGPatterns.cpp:2011
@@ -2013,3 +2010,3 @@
     if (!OnlyOnRHSOfCommutative(getChild(getNumChildren()-1))) {
-      bool Skip = isCommIntrinsic ? 1 : 0; // First operand is intrinsic id.
+      unsigned Skip = isCommIntrinsic ? 1 : 0; // First operand is intrinsic id.
       for (unsigned i = Skip, e = getNumChildren()-1; i != e; ++i)
----------------
Is this used in the rest of the scope?


Repository:
  rL LLVM

https://reviews.llvm.org/D24325