[PATCH] D24420: AMDGPU: Use brev for materializing SGPR constants
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 9 13:14:01 PDT 2016
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIShrinkInstructions.cpp:333
@@ +332,3 @@
+ if (Src.isImm()) {
+ int32_t ReverseImm;
+ if (isKImmOperand(TII, Src))
----------------
mgrang wrote:
> else-if can be changed to an else and ReverseImm can be moved inside the else part.
That will increase the level of indentation
https://reviews.llvm.org/D24420
More information about the llvm-commits
mailing list