[PATCH] D24404: COFF: make builds more reproducible

[Saleem Abdulrasool via llvm-commits]

compnerd marked 4 inline comments as done.

================
Comment at: COFF/Writer.cpp:87
@@ +86,3 @@
+    DI->Signature.CVSignature = OMF::Signature::PDB70;
+    memset(DI->PDB70.Signature, 0, sizeof(DI->PDB70.Signature));
+    DI->PDB70.Age = 0;
----------------
ruiu wrote:
> It's a fresh file, so as long as you don't write anything, zeros are there, so this is a nop.
Zapped.

================
Comment at: COFF/Writer.cpp:98
@@ +97,3 @@
+public:
+  mutable codeview::DebugInfo *DI;
+
----------------
ruiu wrote:
>   DI = nullptr;
Oh, right, forgot about that.  Nice!  Changed to the initializer and zapped the constructor.


Repository:
  rL LLVM

https://reviews.llvm.org/D24404