[PATCH] D24336: [ELF] - Versionscript: support mangled symbols with the same name.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 9 10:14:47 PDT 2016
ruiu added inline comments.
================
Comment at: ELF/SymbolTable.h:104
@@ -103,3 +103,3 @@
- std::map<std::string, SymbolBody *> getDemangledSyms();
+ std::map<std::string, std::vector<SymbolBody *>> getDemangledSyms();
----------------
grimar wrote:
> ruiu wrote:
> > It seems you want to use multimap instead of map + vector.
> Problably I am missing something, but my question is: for what ?
> I see no difference here.
I meant `std::multimap<X, Y>` is a more natural choice than `std::map<X, std::vector<Y>>`.
https://reviews.llvm.org/D24336
More information about the llvm-commits
mailing list