[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

[Filipe Cabecinhas via llvm-commits]

filcab updated this revision to Diff 70852.
filcab added a comment.

Updated with review comments.
I wasn't looking at the class properly, it fits in an Error* structure and the type is still trivially-copyable.

Vitaly: I changed the patch a bit from yours. I think it ends up being simpler to have code like:

  if (auto shadow = descr.AsShadow()) {
    ...
  } else ...

Than to have the switch on .Kind(), since there's more code (reading) overhead with the switch.

I kept the const you added to the methods like Print(), but I can take them out and do a follow-up patch (or do it before) if you'd prefer.

Thank you,

Filipe


https://reviews.llvm.org/D24131

Files:
  lib/asan/asan_debugging.cc
  lib/asan/asan_descriptions.cc
  lib/asan/asan_descriptions.h
  lib/asan/asan_report.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24131.70852.patch
Type: text/x-patch
Size: 11272 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160909/15cded50/attachment.bin>