[PATCH] D24316: Write the TPI stream from Yaml

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: include/llvm/DebugInfo/CodeView/FieldListSerializationVisitor.h:1
@@ +1,2 @@
+//===- FieldListSerializationVisitor.h --------------------------*- C++ -*-===//
+//
----------------
Is this header actually used? It seems like this part is rolled into TypeSerializationVisitor.

================
Comment at: include/llvm/DebugInfo/MSF/SequencedItemStream.h:28
@@ +27,3 @@
+
+/// SequencedItemStream represents a sequence of objects stored in a
+/// standard container but for which it is useful to view as a stream of
----------------
I guess I'm surprised that we're still having to build scaffolding like this. I kind of thought that we had all the stream-y sequence-y primitives in MSF that we needed at this point.

I don't have any real suggestions on how to improve this, just a general comment.

================
Comment at: include/llvm/DebugInfo/MSF/SequencedItemStream.h:36
@@ +35,3 @@
+/// extract one item at a time, allowing the data to be used anywhere a
+/// VarStreamArray coudl be used.
+template <typename T, typename Traits = SequencedItemTraits<T>>
----------------
typo


https://reviews.llvm.org/D24316