[PATCH] D24337: Fix the Thumb test for vfloat intrinsics

[Renato Golin via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D24337#538293, @pbarrio wrote:

> On second thoughts, I have tested with a modern gcc and it marks all functions with either .thumb or .arm (equivalent to .code 16/32). So, essentially, that behaviour is what this patch suggests. Another thing that surprised me is that Thumb appears to be the default, contrary to the LLVM default which is ARM.


Oh, there it is, GCC 6 does it. You are right!

> When you talk about preserving the "original GNU" behaviour, do you mean an old GNU toolchain? If so, why should we preserve an ancient behaviour?


I surely am, and I agree with you it should be fine.

Even if we still don't have a solution for all the other directives, ARM/Thumb is probably more critical than any other.

Please, split this patch with just the .code and re-submit.

Sorry for the noise.

--renato


https://reviews.llvm.org/D24337