[PATCH] D24342: Compact InputSectionData from 64 to 48 bytes

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 04:57:21 PDT 2016


rafael added inline comments.

================
Comment at: ELF/InputSection.h:62-63
@@ -63,1 +61,4 @@
+  // If a section is compressed, this has the uncompressed section data.
+  std::unique_ptr<char> UncompressedData;
+  size_t UncompressedDataSize = 0;
 
----------------
ruiu wrote:
> My preference is to use std::vector instead of char * and size.
std::vector is still 3 pointers.

What I want to do next is to always have a valid StringRef (or ArrayRef) with the data. Initially it points to the mmaped file. After decompression it points to UncompressedData and UncompressedDataSize can be removed.


https://reviews.llvm.org/D24342





More information about the llvm-commits mailing list