[PATCH] D24341: Add a lower level zlib::uncompress

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 04:54:57 PDT 2016


rafael added inline comments.

================
Comment at: include/llvm/Support/Compression.h:46
@@ -45,1 +45,3 @@
 
+Status uncompress(StringRef InputBuffer, char *UncompressedBuffer,
+                  size_t &UncompressedSize);
----------------
ruiu wrote:
> `uint8_t *` is better than `char *`, no?
Probably not in here since the rest of the API uses SmallVectorImpl<char>. We could change the rest to use SmallVectorImpl<uint8_t>, but should be another patch.


https://reviews.llvm.org/D24341





More information about the llvm-commits mailing list