[PATCH] D23896: [InstCombine] Try to resubmit the combine of A->B->A BitCast and fix for pr27996
Evgeny Stupachenko via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 8 22:52:15 PDT 2016
evstupac added a comment.
Hi,
> InstCombine is supposed to run to fix-point
Have you addressed David's comment?
Am I right that current fix-point is when all CI users are memory instructions?
Thanks,
Evgeny
================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:1806
@@ +1805,3 @@
+
+ auto *LI = dyn_cast<LoadInst>(IncValue);
+ if (LI) {
----------------
To follow one stile you I'd put LI definition into comparison.
https://reviews.llvm.org/D23896
More information about the llvm-commits
mailing list