[PATCH] D24370: Add support for writing TPI hash values
David Majnemer via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 8 20:06:23 PDT 2016
majnemer added a subscriber: majnemer.
================
Comment at: include/llvm/DebugInfo/PDB/Raw/TpiRecordHashVisitor.h:26
@@ +25,3 @@
+public:
+ TpiRecordHashUpdateVisitor() {}
+
----------------
`TpiRecordHashUpdateVisitor() = default;` ?
================
Comment at: include/llvm/DebugInfo/PDB/Raw/TpiRecordHashVisitor.h:56-59
@@ +55,6 @@
+public:
+ TpiRecordHashVerificationVisitor(
+ msf::FixedStreamArray<support::ulittle32_t> &HashValues,
+ uint32_t NumHashBuckets)
+ : HashValues(HashValues), NumHashBuckets(NumHashBuckets) {}
+
----------------
Is this clang-formatted?
================
Comment at: lib/DebugInfo/PDB/Raw/TpiStream.cpp:105-107
@@ -195,2 +104,5 @@
return EC;
+ std::vector<ulittle32_t> HashValueList;
+ for (auto I : HashValues)
+ HashValueList.push_back(I);
----------------
Couldn't you just do `std::vector<ulittle32_t> HashValueList(HashValueList.begin(), HashValueList.end());`
================
Comment at: test/DebugInfo/PDB/pdbdump-readwrite.test:13-18
@@ -12,8 +12,8 @@
CHECK-NEXT: NumBlocks: 25
-CHECK-NEXT: NumDirectoryBytes: 136
+CHECK-NEXT: NumDirectoryBytes:
CHECK-NEXT: Unknown1: 0
-CHECK-NEXT: BlockMapAddr: 24
+CHECK-NEXT: BlockMapAddr:
CHECK-NEXT: NumDirectoryBlocks: 1
-CHECK-NEXT: DirectoryBlocks: [23]
-CHECK-NEXT: NumStreams: 17
+CHECK-NEXT: DirectoryBlocks:
+CHECK-NEXT: NumStreams:
CHECK-NEXT: }
----------------
Is this diff correct?
https://reviews.llvm.org/D24370
More information about the llvm-commits
mailing list