[llvm] r281008 - [llvm-cov] Speculate fix for a Windows-only test (NFC)

[Vedant Kumar via llvm-commits]

Hi Maggie,

Sorry for breaking this test!

Could you help test this out? I don't have a Windows machine available.

thanks!
vedant

> On Sep 8, 2016, at 6:32 PM, Vedant Kumar via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: vedantk
> Date: Thu Sep  8 20:32:47 2016
> New Revision: 281008
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=281008&view=rev
> Log:
> [llvm-cov] Speculate fix for a Windows-only test (NFC)
> 
> This test should have broken after r280896. Fix up the test case
> speculatively, since I don't have a way to test it.
> 
> I wonder why I didn't get any angry bot emails about this. Maybe none of
> the win32 bots test llvm-cov? That could explain it, since the test says
> it 'REQUIRES: system-windows', which is restricted to win32 hosts.
> 
> Also: why is 'system-windows' not defined for non-win32 Windows bots?
> 
> Modified:
>    llvm/trunk/test/tools/llvm-cov/native_separators.c
> 
> Modified: llvm/trunk/test/tools/llvm-cov/native_separators.c
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cov/native_separators.c?rev=281008&r1=281007&r2=281008&view=diff
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-cov/native_separators.c (original)
> +++ llvm/trunk/test/tools/llvm-cov/native_separators.c Thu Sep  8 20:32:47 2016
> @@ -15,15 +15,13 @@
> 
> // TEXT-INDEX: \tmp\native_separators.c
> // HTML-INDEX: >tmp\native_separators.c</a>
> -// HTML: <pre>Source: \tmp\native_separators.c</pre>
> -// HTML: tools\llvm-cov\Inputs\native_separators.covmapping</pre>
> +// HTML: <pre>Source: \tmp\native_separators.c (Binary: native_separators.covmapping)</pre>
> 
> int main() {}
> 
> // RUN: llvm-cov show %S/Inputs/native_separators.covmapping -instr-profile=%t.profdata -filename-equivalence %s -o %t.dir
> // RUN: FileCheck -check-prefixes=TEXT -input-file=%t.dir/coverage/tmp/native_separators.c.txt %s
> -// TEXT: {{^}}Source: \tmp\native_separators.c:{{$}}
> -// TEXT: {{^}}Binary: {{.*}}tools\llvm-cov\Inputs\native_separators.covmapping:{{$}}
> +// TEXT: Source: \tmp\native_separators.c (Binary: native_separators.covmapping)
> 
> // Re-purpose this file to test that "Go to first unexecuted line" feature.
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits