[PATCH] D24060: [lld][ELF] Add support for -b binary

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 17:17:45 PDT 2016


OK, I don't want to make future upstreaming unnecessarily hard by
requesting changes to that file, so I'm okay with that file structure. That
said, please keep it in mind that this file would diverge from what it is
today once we submit this to the open source repository because people
would try to improve it, and we can't stop them if it is a good change.
Even I would try to make changes to that file if upstreaming won't be done
in a timely manner.

On Thu, Sep 8, 2016 at 5:04 PM, Sean Silva <chisophugis at gmail.com> wrote:

>
>
> On Thu, Sep 8, 2016 at 3:19 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>> On Thu, Sep 8, 2016 at 3:14 PM, Sean Silva <chisophugis at gmail.com> wrote:
>>
>>> silvas added a subscriber: silvas.
>>>
>>> ================
>>> Comment at: ELF/InputFiles.cpp:736
>>> @@ +735,3 @@
>>> +template <class ELFT> std::unique_ptr<InputFile>
>>> BinaryFile::createELF() {
>>> +  ELFCreator<ELFT> ELF(ET_REL, Config->EMachine);
>>> +  auto DataSec = ELF.addSection(".data");
>>> ----------------
>>> ruiu wrote:
>>> > Bigcheese wrote:
>>> > > ruiu wrote:
>>> > > > How about this?
>>> > > Well, the code doesn't belong in ELFCreator.cpp. I can make a
>>> BinaryFile.cpp for it, but it's only 40 lines of code.
>>> > That distinction doesn't make much sense to me because this is part of
>>> the linker. If you have a concrete plan to move ELFCreator to some library,
>>> it may make sense, but it doesn't seem to happen soon.
>>> Like Michael already said, ELFCreator is already used in at least 2
>>> other places for PS4. It doesn't make sense to move this
>>> BinaryFile-specific code into ELFCreator.
>>>
>>
>> Is that change for PS4 upstreamed?
>>
>
> Not yet. Right now, we are required to keep those private, but we try to
> do things so that they are ready to be sent upstream if we get the approval
> to do so (e.g. we merge the latest LLD daily).
>
> -- Sean Silva
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160908/40d89524/attachment.html>


More information about the llvm-commits mailing list