[PATCH] D24060: [lld][ELF] Add support for -b binary

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 17:17:49 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/InputFiles.h:310
@@ +309,3 @@
+private:
+  std::unique_ptr<char[]> ELFData;
+};
----------------
Is this equivalent to `std::unique_ptr<char *>`? If so, please write that way.

Can you use uint8_t instead of char?


https://reviews.llvm.org/D24060





More information about the llvm-commits mailing list