[PATCH] D23601: [TII] add new target hook isAdd
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 8 16:36:34 PDT 2016
qcolombet accepted this revision.
qcolombet added a reviewer: qcolombet.
qcolombet added a comment.
This revision is now accepted and ready to land.
Hi Sjoerd,
Yes, that was what I had in mind.
For some reasons though, the reply I made to Hal's proposal didn't make it to phabricator so I guess you missed it. Basically, I was saying that Hal's proposal was a good way to move.
That being said, I don't what to hold on that patch, I guess we could move towards the more generic approach in a follow up patch or when we want to add more semantic.
Just one thing, please do the replacement of 1<< by 1ULL<< in a different patch that you would apply first.
Cheers,
-Quentin
https://reviews.llvm.org/D23601
More information about the llvm-commits
mailing list