[PATCH] D24340: [ELF] Linkerscript: support [ AT ( address ) ] in PHDRS

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Writer.cpp:1171
@@ -1170,5 +1170,3 @@
 
-    H.p_paddr = H.p_vaddr;
-    if (H.p_type == PT_LOAD && First)
-      if (Expr LmaExpr = Script<ELFT>::X->getLma(First->getName()))
-        H.p_paddr = LmaExpr(H.p_vaddr);
+    if (!P.HasLMA) {
+      H.p_paddr = H.p_vaddr;
----------------
It needs comment.

  // p_paddr can be set using linker script AT command.
  // By default, it is the same value as p_vaddr.


Repository:
  rL LLVM

https://reviews.llvm.org/D24340