[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 11:59:48 PDT 2016


If I could stop caring about VS2013, that would be good enough. My problem
is that having it this way will force us to copy the data whenever we want
to use it from a structure that need to be put in a union (because of
VS2013), since you can only put a *Data in there, not the full
AddressDescription.

Thank you,
 Filipe

On Thursday, 8 September 2016, Vitaly Buka <vitalybuka at google.com> wrote:

> vitalybuka requested changes to this revision.
> This revision now requires changes to proceed.
>
> ================
> Comment at: lib/asan/asan_descriptions.h:185
> @@ +184,3 @@
> +  // We should be able to do without this struct after we deprecate
> VS2013.
> +  AddressKind kind;
> +  union {
> ----------------
> I like this way:  https://reviews.llvm.org/D24358
> WDYT?
>
>
> https://reviews.llvm.org/D24131
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160908/7c67f861/attachment.html>


More information about the llvm-commits mailing list