[PATCH] D24060: [lld][ELF] Add support for -b binary

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/CMakeLists.txt:20
@@ -19,2 +19,3 @@
   ScriptParser.cpp
+  SimpleELFWriter.cpp
   Strings.cpp
----------------
I still don't like this file name. `SimpleELFWriter` sounds like it is for -o binary instead of -b. Can you rename BinaryFile.cpp?

================
Comment at: ELF/InputFiles.cpp:736
@@ +735,3 @@
+template <class ELFT> std::unique_ptr<InputFile> BinaryFile::createELF() {
+  SimpleELFWriter<ELFT> ELF(ET_REL, Config->EMachine);
+  auto DataSec = ELF.addSection(".data");
----------------
Please move these details to SimpleELFWriter.cpp.


https://reviews.llvm.org/D24060