[polly] r280946 - GICHelper: Correctly assign return value

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 07:34:54 PDT 2016


Author: grosser
Date: Thu Sep  8 09:34:54 2016
New Revision: 280946

URL: http://llvm.org/viewvc/llvm-project?rev=280946&view=rev
Log:
GICHelper: Correctly assign return value

... to preserve reference counting logic.

In practice the missing assignment would not have caused any issues. We still
fix it as the code is wrong and it also causes noise in the clang static
analysis runs.

Modified:
    polly/trunk/lib/Support/GICHelper.cpp

Modified: polly/trunk/lib/Support/GICHelper.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Support/GICHelper.cpp?rev=280946&r1=280945&r2=280946&view=diff
==============================================================================
--- polly/trunk/lib/Support/GICHelper.cpp (original)
+++ polly/trunk/lib/Support/GICHelper.cpp Thu Sep  8 09:34:54 2016
@@ -99,7 +99,7 @@ static inline std::string stringFromIslO
     return "null";
   isl_ctx *ctx = ctx_getter_fn(isl_obj);
   isl_printer *p = isl_printer_to_str(ctx);
-  printer_fn(p, isl_obj);
+  p = printer_fn(p, isl_obj);
   char *char_str = isl_printer_get_str(p);
   std::string string;
   if (char_str)




More information about the llvm-commits mailing list