[PATCH] D23352: [ELF] - Linkerscript: implemented simple heuristic for placing orphan sections.

[Ed Maste via llvm-commits]

emaste added a subscriber: emaste.
emaste added a comment.

While attempting to apply the patch locally for testing I encountered line ending issues and two conflicts marked above.


================
Comment at: ELF/LinkerScript.cpp:294
@@ -242,3 +293,3 @@
       if (IsNew)
-        OutputSections->push_back(OutSec);
+        Cmd->OutputSection = OutSec;
 
----------------
patch failed to apply for me with a conflict here

================
Comment at: test/ELF/linkerscript/symbols-synthetic.s:53-65
@@ -52,15 +52,15 @@
 
-# SIMPLE:      0000000000000160         .foo    00000000 .hidden _end_sec
-# SIMPLE:      0000000000000158         .foo    00000000 _begin_sec
-# SIMPLE-NEXT: 0000000000000158         .foo    00000000 begin_foo
-# SIMPLE-NEXT: 0000000000000160         .foo    00000000 end_foo
-# SIMPLE-NEXT: 0000000000000008         .foo    00000000 size_foo_1
-# SIMPLE-NEXT: 0000000000001000         .foo    00000000 begin_bar
-# SIMPLE-NEXT: 0000000000001004         .foo    00000000 end_bar
-# SIMPLE-NEXT: 0000000000000eac         .foo    00000000 size_foo_2
-# SIMPLE-NEXT: 0000000000000eac         *ABS*   00000000 size_foo_3
-# SIMPLE-NEXT: 0000000000001004         .eh_frame_hdr     00000000 __eh_frame_hdr_start
-# SIMPLE-NEXT: 0000000000001010         .eh_frame_hdr     00000000 __eh_frame_hdr_start2
-# SIMPLE-NEXT: 0000000000001018         .eh_frame_hdr     00000000 __eh_frame_hdr_end
-# SIMPLE-NEXT: 0000000000001020         .eh_frame_hdr     00000000 __eh_frame_hdr_end2
+# SIMPLE:       0000000000000198         .foo		 00000000 .hidden _end_sec
+# SIMPLE:       0000000000000190         .foo		 00000000 _begin_sec
+# SIMPLE-NEXT:  0000000000000190         .foo		 00000000 begin_foo
+# SIMPLE-NEXT:  0000000000000198         .foo		 00000000 end_foo
+# SIMPLE-NEXT:  0000000000000008         .foo		 00000000 size_foo_1
+# SIMPLE-NEXT:  0000000000001000         .foo		 00000000 begin_bar
+# SIMPLE-NEXT:  0000000000001004         .foo		 00000000 end_bar
+# SIMPLE-NEXT:  0000000000000e74         .foo		 00000000 size_foo_2
+# SIMPLE-NEXT:  0000000000000e74         *ABS*		 00000000 size_foo_3
+# SIMPLE-NEXT:  0000000000001004         .eh_frame_hdr		 00000000 __eh_frame_hdr_start
+# SIMPLE-NEXT:  0000000000001010         .eh_frame_hdr		 00000000 __eh_frame_hdr_start2
+# SIMPLE-NEXT:  0000000000001018         .eh_frame_hdr		 00000000 __eh_frame_hdr_end
+# SIMPLE-NEXT:  0000000000001020         .eh_frame_hdr		 00000000 __eh_frame_hdr_end2
 # ERROR: section '.eh_frame_hdr' supports only start and end symbols
----------------
conflict here


https://reviews.llvm.org/D23352