[PATCH] D24220: [UNWIND] Handle non-existing FDE count / search table
Ed Maste via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 8 07:21:14 PDT 2016
emaste added a comment.
For future uploads can you please include context (`git diff -U9999`, `svn diff --diff-cmd=diff -x -U999999` etc.)
================
Comment at: src/AddressSpace.hpp:224-226
@@ -223,1 +223,5 @@
+ if (encoding == DW_EH_PE_omit) {
+ return (pint_t)NULL;
+ }
+
----------------
This is the one in NetBSD already (although as `return 0`). @joerg also has another case there:
```
if (encoding == DW_EH_PE_omit)
return 0;
if (encoding == DW_EH_PE_aligned) {
addr = (addr + sizeof(pint_t) - 1) & sizeof(pint_t);
return getP(addr);
}
// first get value
```
@joerg would you upstream these changes from NetBSD's copy?
Repository:
rL LLVM
https://reviews.llvm.org/D24220
More information about the llvm-commits
mailing list