[PATCH] D24337: Fix the Thumb test for vfloat intrinsics

[Pablo Barrio via llvm-commits]

pbarrio added a comment.

Ah, sorry. They are two different changes in my tree, and I thought arcanist would preserve that but it didn't. I will make sure that they are submitted as separate patches.


================
Comment at: test/CodeGen/ARM/vfloatintrinsics.ll:322
@@ -321,3 +321,1 @@
 }
-; CHECK: test_v2f64.fabs:
-define %v2f64 @test_v2f64.fabs(%v2f64 %a) {
----------------
jmolloy wrote:
> Why has this testcase been removed?
This testcase was failing after my changes: the currenty generated assembly is not calling an fabs intrinsic but a series of bfc and vmovs.

I am not sure what the right checks would be, so I have removed this part of the test (as it's not currently testing anything useful anyway). I have added aschwaighofer as a reviewer, who is the original author, as he may know what the correct test would be.


https://reviews.llvm.org/D24337