[lld] r280858 - Move field to the base class. NFC.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 05:01:09 PDT 2016


Given that it doesn't depend on the template argument, it seems better
to have it in the base class.

Cheers,
Rafael


On 7 September 2016 at 16:58, Rui Ueyama <ruiu at google.com> wrote:
> Why?
>
> On Wed, Sep 7, 2016 at 1:41 PM, Rafael Espindola via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: rafael
>> Date: Wed Sep  7 15:41:19 2016
>> New Revision: 280858
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=280858&view=rev
>> Log:
>> Move field to the base class. NFC.
>>
>> Modified:
>>     lld/trunk/ELF/InputSection.h
>>
>> Modified: lld/trunk/ELF/InputSection.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputSection.h?rev=280858&r1=280857&r2=280858&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/ELF/InputSection.h (original)
>> +++ lld/trunk/ELF/InputSection.h Wed Sep  7 15:41:19 2016
>> @@ -53,6 +53,8 @@ public:
>>    bool Compressed;
>>    // If a section is compressed, this vector has uncompressed section
>> data.
>>    SmallVector<char, 0> Uncompressed;
>> +
>> +  std::vector<Relocation> Relocations;
>>  };
>>
>>  // This corresponds to a section of an input file.
>> @@ -102,7 +104,6 @@ public:
>>    void uncompress();
>>
>>    void relocate(uint8_t *Buf, uint8_t *BufEnd);
>> -  std::vector<Relocation> Relocations;
>>  };
>>
>>  template <class ELFT> InputSectionBase<ELFT>
>> InputSectionBase<ELFT>::Discarded;
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>


More information about the llvm-commits mailing list