[PATCH] D24310: [Polly] Add -polly-flatten-schedule pass.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 03:37:19 PDT 2016


Meinersbur marked 4 inline comments as done.

================
Comment at: include/polly/Support/GICHelper.h:409
@@ -180,1 +408,3 @@
+    const std::function<isl_stat(IslPtr<isl_set>, IslPtr<isl_aff>)> &F);
+
 } // end namespace polly
----------------
jdoerfert wrote:
> Tobias accepted this already but I would have assumed all these things to be in different patches. Maybe I'm wrong since I didnt read the whole patch but I just don't know what these isl++ replacements and the new isl foreach functions have to do with the flatten algorithm (or with Polly for that matter).
I proposed this, but in the long-term we'd want a proper ISL C++ interface. We do not want to port other code to use this smart pointer, making FlattenSchedule currently the only place where it is used.


https://reviews.llvm.org/D24310





More information about the llvm-commits mailing list