[PATCH] D24317: Emit S_COMPILE3 CodeView record

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:574-575
@@ +573,4 @@
+  OS.AddComment("CPUType");
+  CPUType CPU =
+      (getPointerSizeInBytes() == 8) ? CPUType::X64 : CPUType::Pentium3;
+  OS.EmitIntValue(static_cast<uint64_t>(CPU), 2);
----------------
I'd make it a switch on the triple's architecture (`Triple(MMI->getModule()->getTargetTriple()).getArch()`).  Clang also supports ARMNT.

I'd have the default label call `report_fatal_error` to indicate that the architecture is not supported.


https://reviews.llvm.org/D24317