[PATCH] D24203: [LoopUnroll] Properly update loop-info when cloning prologues and epilogues.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 16:33:45 PDT 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Really nice. LGTM with straight forward comments / refactorings below.


================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:307-309
@@ +306,5 @@
+    const Loop *OldLoop = LI->getLoopFor(*BB);
+    Loop *&NewLoop = NewLoops[OldLoop];
+    if (!NewLoop) {
+      if (CreateRemainderLoop || OldLoop != L) {
+        // This is a first block belonging to OldLoop encountered in our RPO
----------------
Factoring this into a helper or a lambda would make it more readable IMO because you could use early returns.


https://reviews.llvm.org/D24203





More information about the llvm-commits mailing list