[PATCH] D24321: [asan] Avoid lifetime analysis for allocas with can be in ambiguous state

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 15:50:08 PDT 2016


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:838
@@ +837,3 @@
+  DenseMap<const BasicBlock *, bool> Markers;
+  DenseMap<const BasicBlock *, bool> InboundState;
+  bool Processed = false;
----------------
please add short comments for these two maps

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:845
@@ +844,3 @@
+    auto Successors =
+        make_range(succ_begin(BlockState.first), succ_end(BlockState.first));
+    for (const BasicBlock *SB : Successors)
----------------
succ_range


https://reviews.llvm.org/D24321





More information about the llvm-commits mailing list