[PATCH] D24310: [Polly] Add -polly-flatten-schedule pass.

[Tobias Grosser via llvm-commits]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

This looks good to me. Thank you Michael.


================
Comment at: include/polly/Support/GICHelper.h:230
@@ +229,3 @@
+/// Most ISL objects are reference counted such that we gain an automatic memory
+/// management.
+///
----------------
Rewrap the paragraph?

================
Comment at: include/polly/Support/GICHelper.h:239
@@ +238,3 @@
+/// function. The IslPtr won't be usable anymore and not have to free the object
+/// when destroyed. Use the give() function to wrap the ownership of a returned
+/// isl_* object into an IstPtr<isl_*>.
----------------
The IslPtr ...

I don't get the grammar here.

================
Comment at: include/polly/Support/GICHelper.h:352
@@ +351,3 @@
+void isl_foreach(NonowningIslPtr<isl_union_map> UMap,
+                 const std::function<void(IslPtr<isl_map> Map)> &F);
+
----------------
Interesting!

================
Comment at: lib/Transform/FlattenAlgo.cpp:24
@@ +23,3 @@
+
+/// Whether a dimension of a set is bounded (lower and upper) by a a constant,
+/// ie. there are two constants Min and Max, such that every value x of the
----------------
a a

================
Comment at: lib/Transform/FlattenAlgo.cpp:36
@@ +35,3 @@
+
+/// Whether a dimension of a set has is (lower and upper) bounded by a constants
+/// or parameters, ie. there are two expressions Min_p and Max_p of the
----------------
has is


https://reviews.llvm.org/D24310