[PATCH] D24092: [compiler-rt] Allow sanitizers to be compiled for windows with clang
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 7 13:03:45 PDT 2016
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Minor thing, otherwise let's do it.
================
Comment at: lib/asan/CMakeLists.txt:217
@@ +216,3 @@
+ set(DYNAMIC_RUNTIME_THUNK_CFLAGS "-DASAN_DYNAMIC_RUNTIME_THUNK")
+ if(CMAKE_C_COMPILER_ID MATCHES Clang)
+ list(APPEND DYNAMIC_RUNTIME_THUNK_CFLAGS "-nodefaultlibs")
----------------
I think clang-cl identifies as clang and MSVC is true, so you want to do `if (MSVC)` first.
https://reviews.llvm.org/D24092
More information about the llvm-commits
mailing list