[PATCH] D24060: [lld][ELF] Add support for -b binary

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 09:45:16 PDT 2016


rafael added a subscriber: rafael.

================
Comment at: ELF/InputFiles.cpp:724
@@ +723,3 @@
+    [](char C) { return isalnum(C) ? C : '_'; });
+  std::string StartSym = "_binary_" + Filename + "_start";
+  std::string EndSym = "_binary_" + Filename + "_end";
----------------
These names look wrong. With gold and bfd I get

_binary__home_espindola_llvm_build_tools_lld_test_ELF_Output_format_binary_test_tmp_binary_start
 _binary__home_espindola_llvm_build_tools_lld_test_ELF_Output_format_binary_test_tmp_binary_size
 _binary__home_espindola_llvm_build_tools_lld_test_ELF_Output_format_binary_test_tmp_binary_end


https://reviews.llvm.org/D24060





More information about the llvm-commits mailing list