[PATCH] D24129: GVN-hoist: disable hoisting stores (PR30216)

[Vasileios Kalintiris via llvm-commits]

> Does it mean that you successfully bootstraped the compiler with this
patch applied?

Unfortunately, no:

https://dmz-portal.mips.com/bb/builders/LLVM%20recurse%20the%20compiler/builds/384/steps/Compare%20object%20files%20from%20cross%20and%20recurse%20builds/logs/stdio

There's a hash mismatch between phase2 & phase3 for the
/tools/clang/lib/Sema/CMakeFiles/clangSema.dir/SemaExprObjC.cpp.o
object. There's a new hash mismatch for ARMBaseRegisterInfo.cpp.o
too, but I'm not sure that GVN-hoist is responsible for that.

- V. Kalintiris

________________________________________
From: Sebastian Pop [sebpop at gmail.com]
Sent: 02 September 2016 14:00
To: reviews+D24129+public+8803f537e8ceb5fb at reviews.llvm.org
Cc: Daniel Berlin; Vasileios Kalintiris; llvm-commits
Subject: Re: [PATCH] D24129: GVN-hoist: disable hoisting stores (PR30216)

It looks like that we forgot to move that testcase under
test/Transforms/GVNHoist/
I will fix that testcase and move it in the right place.

Does it mean that you successfully bootstraped the compiler with this
patch applied?

Thanks,
Sebastian

On Fri, Sep 2, 2016 at 6:35 AM, Vasileios Kalintiris
<Vasileios.Kalintiris at imgtec.com> wrote:
> vkalintiris added a subscriber: vkalintiris.
> vkalintiris added a comment.
>
> Hi Sebastian. I tried this on one of our BB that tests recursive builds and test/Transforms/GVN/pr28626.ll is failing. I'm getting the same failure on an X86_64 host.
>
>   -- Testing: 1 tests, 1 threads --
>   FAIL: LLVM :: Transforms/GVN/pr28626.ll (1 of 1)
>   ******************** TEST 'LLVM :: Transforms/GVN/pr28626.ll' FAILED *************
>   *******
>   Script:
>   --
>   /home/vk/build/llvm/debug/./bin/opt -S -gvn-hoist < /home/vk/repos/llvm/test/Trans
>   forms/GVN/pr28626.ll | /home/vk/build/llvm/debug/./bin/FileCheck /home/vk/repos/ll
>   vm/test/Transforms/GVN/pr28626.ll
>   --
>   Exit Code: 1
>
>   Command Output (stderr):
>   --
>   <stdin>:28:2: error: CHECK-NOT: string occurred!
>    store i1 %c.0, i1* %rc5, align 4
>    ^
>   /home/vk/repos/llvm/test/Transforms/GVN/pr28626.ll:42:14: note: CHECK-NOT: pattern
>    specified here
>   ; CHECK-NOT: store
>                ^
>
>   --
>
>   ********************
>   Testing Time: 0.08s
>   ********************
>   Failing Tests (1):
>       LLVM :: Transforms/GVN/pr28626.ll
>
>     Unexpected Failures: 1
>
>
> https://reviews.llvm.org/D24129
>
>
>