[PATCH] D24131: Add NewAddressDescription, which can describe any type of address.

[Filipe Cabecinhas via llvm-commits]

filcab added a comment.

Bring over a comment from https://reviews.llvm.org/D24132 that wasn't submitted.


================
Comment at: lib/asan/asan_debugging.cc:87
@@ +86,3 @@
+  if (name && name_size > 0) name[0] = 0;
+  switch (descr.kind) {
+    case kAddressKindWild:
----------------
If we add the default case, we get a clang warning, though. I can add a check that we have one of those, before the switch, but it will end up ugly:

`CHECK(descr.kind == kAddressKindWild || descr.kind == kAddressKindShadow || ...);`
Should we also fix places like PrintHeapChunkAccess in asan_descriptions.cc, which does the same thing (not have a default case)?



https://reviews.llvm.org/D24131