[PATCH] D24244: SHL instruction crash in CodeGen - Fixed

[Elena Demikhovsky via llvm-commits]

delena marked an inline comment as done.
delena added a comment.

In https://reviews.llvm.org/D24244#535645, @RKSimon wrote:

> Any chance that the test case can be simplified (i.e. de-bugpointified) a little?


I did my best. I worked hard after the bugpoint gave up.


================
Comment at: ../lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1080
@@ +1079,3 @@
+        // to update the parent node.
+        if (SAO != Node->getOperand(1))
+          NewNode = DAG.UpdateNodeOperands(Node, Node->getOperand(0), SAO);
----------------
RKSimon wrote:
> So are you saying that if SAO == Node->getOperand(1) then its guaranteed to be already legal? Do we need to assert this?
No. I say that SAO node will legalized in the next round. Legalization of more than one node together may crash. 


Repository:
  rL LLVM

https://reviews.llvm.org/D24244