[llvm] r280796 - [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory address.

[Renato Golin via llvm-commits]

On 7 September 2016 at 10:45, Sagar Thakur via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: slthakur
> Date: Wed Sep  7 04:45:37 2016
> New Revision: 280796
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280796&view=rev
> Log:
> [EfficiencySanitizer] Adds shadow memory parameters for 40-bit virtual memory address.
>
> Adding 40-bit shadow memory parameters because MIPS64 uses 40-bit virtual memory addresses.

Hi,

This change broke AArch64 buildbots:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/10001

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/11466



>  bool EfficiencySanitizer::initOnModule(Module &M) {
> +
> +  Triple TargetTriple(M.getTargetTriple());
> +  switch (TargetTriple.getArch()) {
> +    case Triple::x86_64:
> +      ShadowParams = ShadowParams48;
> +      break;
> +    case Triple::mips64:
> +    case Triple::mips64el:
> +      ShadowParams = ShadowParams40;
> +      break;
> +    default:
> +      report_fatal_error("unsupported architecture");
> +  }
> +

This change doesn't make sense.

If the tests were working on AArch64, so there's no reason to block them here.

I'm reverting this patch, please send it for review again, copy
Adhemerval and me, so we can make sure it also works on AArch64.

cheers,
--renato