[PATCH] D24135: [ELF] Linkerscript: support ABSOLUTE keyword in symbol assignment expression

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/LinkerScript.cpp:189
@@ -182,2 +188,3 @@
   DenseSet<InputSectionBase<ELFT> *> SectionIndex;
+  std::vector<SymbolAssignment *> Symbols;
 
----------------
This seems to be dead.

================
Comment at: ELF/LinkerScript.cpp:1166-1167
@@ -1144,2 +1165,4 @@
   assert(Op == "=" || Op == "+=");
-  Expr E = readExpr();
+  if (peek() == "ABSOLUTE") {
+    next();
+    E = readParenExpr();
----------------
  if (skip("ABSOLUTE")) {


https://reviews.llvm.org/D24135