[PATCH] D24229: [ELF] - Versionscript: do not treat non-wildcarded names as wildcards.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 16:30:45 PDT 2016


ruiu added a comment.

With this patch, the existence of double quotes affects how strings will be interpreted later. Such grammar seems really weird to me. Are you sure that the grammar is correct? You are making

  foo::*

to match `foo::bar`, while

  "foo::*"

does not match `foo::bar`.


================
Comment at: test/ELF/version-script-extern-exact.s:6
@@ +5,3 @@
+# RUN:   global:             \
+# RUN:      extern "C++" {   \
+# RUN:         \"aaa*\";    \
----------------
You need to escape '"' in this line too.


https://reviews.llvm.org/D24229





More information about the llvm-commits mailing list