[PATCH] D24095: [lib/LTO] Add a way to run a custom pipeline

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: lib/LTO/LTOBackend.cpp:180
@@ -138,3 +179,3 @@
 
 bool opt(Config &C, TargetMachine *TM, unsigned Task, Module &M,
          bool IsThinLto) {
----------------
> About centralizing somewhere, maybe.
> This can probably be shared with opt but I'd like to discuss this with Chandler before exposing a new API. So I'll leave the static helper here for now.

Sorry, it does not make sense to me, opt has to need the same thing.
(indeed I just checked and it is calling `llvm::runPassPipeline`. Why aren't you using it?)

> I'd rather be consistent with what's there already, and change the whole naming convention in a second pass, if you don't mind.

If you don't want to break consistency, that's fine: first change the names in the whole file, and then update this patch.


https://reviews.llvm.org/D24095