[PATCH] D22076: GVN: If X > Y is true, then replace X == Y with false and X != Y with true

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 12:09:02 PDT 2016


dberlin added inline comments.

================
Comment at: lib/Transforms/Scalar/GVN.cpp:2032
@@ +2031,3 @@
+            Cmp->isTrueWhenEqual() != isKnownTrue) {
+          GVN::replaceInst(NextNum,
+                           VN.lookupOrAddCmp(
----------------
This needs to be factored into a helper function of some sort, or something.
Adding 100 lines of dense duplicated code is ... bad :)


https://reviews.llvm.org/D22076





More information about the llvm-commits mailing list