[PATCH] D24226: [PM] Provide an initial, minimal port of the inliner to the new pass manager.

[Easwaran Raman via llvm-commits]

eraman added inline comments.

================
Comment at: lib/Transforms/IPO/Inliner.cpp:848
@@ +847,3 @@
+
+      // Now walk the basic blocks and instructions that were inlined and add
+      // any new calls to the worklist.
----------------
If only one block is cloned into the caller, it is spliced into the block containing the call instruction. This logic to walk the newly added basic blocks does not work in that case.

================
Comment at: lib/Transforms/IPO/Inliner.cpp:894
@@ +893,3 @@
+    if (!DidInline) {
+      Changed = true;
+      continue;
----------------
Should this be

if (!DidInline)
  continue;
Changed = true;

?


https://reviews.llvm.org/D24226